Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP : arc factory #678

Merged
merged 24 commits into from
Nov 5, 2019
Merged

WIP : arc factory #678

merged 24 commits into from
Nov 5, 2019

Conversation

orenyodfat
Copy link
Contributor

@orenyodfat orenyodfat commented Oct 28, 2019

all schemes are none universals.
uController was removed.
all contracts have one time initialise function.

this is step 1 towards full arc factory solution.

  • all schemes are none universals - all contracts have one time initialise function.
  • daofactory.sol as a factory.
  • tests - daofactory + proxied dao

general solution overview :

  • arc package is imported by migration repo .
  • migration will provides to commands :
  1. migrate base
    - deploy arc contracts
    - setImplementation(contract logic) of the deployed arc contracts at registry contracts.
  2. migrate dao
    • will use DaoFactory.sol to create a DAO according to the params given.This can be done in 2 txs.
    • the output will be dao.json with all the days contract proxied addresses.
  3. subgraph will use <DAONAME>.json to index the dao or just auto index that upon a newOrg event from DAOFacroty (maybe need more events)

@orenyodfat orenyodfat requested a review from leviadam as a code owner October 28, 2019 14:05
@dkent600 dkent600 changed the title none universal contracts non-universal contracts Oct 28, 2019
@orenyodfat orenyodfat changed the title non-universal contracts WIP : arc factory Oct 29, 2019
@orenyodfat orenyodfat merged commit 79278b2 into arc-factory Nov 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants