-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP : arc factory #678
Merged
Merged
WIP : arc factory #678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ben-kaufman
reviewed
Oct 29, 2019
use infra-expiremental
ben-kaufman
approved these changes
Nov 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a preparation for arc registry and factory:
all schemes are none universals.
uController was removed.
all contracts have one time initialise function.
this is step 1 towards full arc factory solution.
general solution overview :
arc
package is imported bymigration
repo .migration
will provides to commands :migrate base
- deploy
arc
contracts- setImplementation(contract logic) of the deployed arc contracts at
registry
contracts.migrate dao
subgraph
will use<DAONAME>.json
to index the dao or just auto index that upon anewOrg
event fromDAOFacroty
(maybe need more events)