Skip to content

Conversation

@osalyk
Copy link
Contributor

@osalyk osalyk commented Oct 31, 2025

This change is Reviewable

Copy link
Contributor

@grom72 grom72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My proposal is to change schedules as:
pmem_test_1 -> Friday 6pm (+8h)
pmem_test_2 -> Saturday 6am (+12h)
pmem_test_3 -> Saturday 6pm

let's build everything during weekend

@grom72 reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @janekmi)

Copy link
Contributor Author

@osalyk osalyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I gave more time between pmem_test_2 and pmem_test_3, the workflow can take up to 24 hours. We don't know yet how long it takes.

Reviewable status: 0 of 3 files reviewed, all discussions resolved (waiting on @grom72 and @janekmi)

Copy link
Contributor

@grom72 grom72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@grom72 reviewed 3 of 3 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @janekmi)

Copy link
Contributor

@janekmi janekmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@janekmi reviewed 3 of 3 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @osalyk)


.github/workflows/pmem_tests_1.yml line 34 at r2 (raw file):

    if: github.repository_owner == 'daos-stack'
    runs-on: [self-hosted, pmdk, rhel, icx]
    timeout-minutes: 1440 # 24h

Suggestion:

    # 3h (as measured + a generous safety margin).
    timeout-minutes: 180

Copy link
Contributor Author

@osalyk osalyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @janekmi)


.github/workflows/pmem_tests_1.yml line 34 at r2 (raw file):

    if: github.repository_owner == 'daos-stack'
    runs-on: [self-hosted, pmdk, rhel, icx]
    timeout-minutes: 1440 # 24h

We don't want to correct it anymore.
I gave the longest possible timeout; if it doesn't fit, it will have to be split anyway.

Copy link
Contributor

@janekmi janekmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @osalyk)

@janekmi janekmi merged commit 467fcef into master Nov 4, 2025
9 checks passed
osalyk added a commit that referenced this pull request Nov 4, 2025
osalyk added a commit that referenced this pull request Nov 4, 2025
janekmi pushed a commit that referenced this pull request Nov 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants