Skip to content

Conversation

@tanabarr
Copy link
Contributor

@tanabarr tanabarr commented Dec 10, 2025

Allow dlck off-line debug tool to create hugepage and dpdk files if
run as a member of the daos_server user-group.

Features: control
Allow-unstable-test: true

Steps for the author:

  • Commit message follows the guidelines.
  • Appropriate Features or Test-tag pragmas were used.
  • Appropriate Functional Test Stages were run.
  • At least two positive code reviews including at least one code owner from each category referenced in the PR.
  • Testing is complete. If necessary, forced-landing label added and a reason added in a comment.

After all prior steps are complete:

  • Gatekeeper requested (daos-gatekeeper added as a reviewer).

Features: control
Allow-unstable-test: true
Signed-off-by: Tom Nabarro <[email protected]>
@tanabarr tanabarr self-assigned this Dec 10, 2025
@github-actions
Copy link

Ticket title is 'DLCK & DDB could use setuid/setgid to be easily runnable by any user in the system'
Status is 'Open'
https://daosio.atlassian.net/browse/DAOS-18324

@daosbuild3
Copy link
Collaborator

Comment on lines +95 to +96
echo "RUN: chown -R ${_TARGET_USER}:${_TARGET_USER} /dev/hugepages"
chown -R "${_TARGET_USER}:${_TARGET_USER}" /dev/hugepages
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor - Might be good to put the command in a variable, so the printed message stays in sync with what's actually run

Co-authored-by: Jan Michalski <[email protected]>
Signed-off-by: Tom Nabarro <[email protected]>
@daosbuild3
Copy link
Collaborator

@tanabarr tanabarr requested review from janekmi and kjacque December 10, 2025 21:26
Comment on lines 99 to 100
echo "RUN: chmod -R g+rw /tmp/dpdk"
echo "RUN: chmod -R g+rwx /tmp/dpdk"
chmod -R g+rw /tmp/dpdk
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, forgot to update the actual command that's run to g+rwx.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad I've committed Jan's suggested change but forgot to check this.

Features: control
Signed-off-by: Tom Nabarro <[email protected]>
@daosbuild3
Copy link
Collaborator

@tanabarr tanabarr added the forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed. label Dec 17, 2025
@tanabarr tanabarr requested a review from a team December 17, 2025 09:51
@tanabarr
Copy link
Contributor Author

CI failing on unrelated permissions/acl failures in NLT test, all others passed. Requesting force Landing.

@daltonbohning daltonbohning merged commit 2b458ed into master Dec 17, 2025
44 of 47 checks passed
@daltonbohning daltonbohning deleted the tanabarr/control-spdk-fileperms-fix branch December 17, 2025 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed.

Development

Successfully merging this pull request may close these issues.

7 participants