DAOS-18264 pool: non-NULL check for sp_map (#17216) #17258
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ds_pool::sp_map could be NULL if the pool map hasn't been populated, a non-NULL check must be performed before accessing. Signed-off-by: Niu Yawei <[email protected]>
NiuYawei
added
the
clean-cherry-pick
|
Ticket title is 'Aurora daos_perf: Server got crashed when try to set NVMe to faulty' |
mchaarawi
reviewed
Dec 10, 2025
| struct pool_domain *tmp; | ||
| int i; | ||
|
|
||
| D_ASSERT(map != NULL); |
Contributor
There was a problem hiding this comment.
could you please explain the reason for adding all those asserts?
Contributor
Author
There was a problem hiding this comment.
Current code can't handle 'map == NULL' case, it indicates a bug if the assert happens. Adding these asserts would be helpful on catching regressions. (if some new code calls these functions with NULL map).
liuxuezhao
approved these changes
Dec 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ds_pool::sp_map could be NULL if the pool map hasn't been populated, a non-NULL check must be performed before accessing.
Steps for the author:
After all prior steps are complete: