Fix DAN-25 - Route map prefix list matching for IPv4 is broken #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
from code inspection, the ip access-list is also incorrect; the standard-acl and extended-acl for address and nexthop, the entries should be combined into one entry for access-list (the equivalent for ipv6 is correct) |
|
Thank you for your contribution! We are still finalizing all the logistics around accepting contributions. The process will be documented here https://danosproject.atlassian.net/wiki/spaces/DAN/pages/3276830/Contributing+to+the+DANOS+source+code. Per this process we require DCO signed-off-by statements in each contributed commit. Please review the DCO text and if you agree to its terms amend your commit with this statement. |
|
Thanks for your contribution. This issue should now be addressed via partial merge of #2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for DAN-25: When using an IPv4 prefix list with a route map there is no match condition added to frr.conf.