Made MAX_WIND_INTENSITY configurable. Fixed links to canvas_layer.js in the examples. #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -83,7 +80,9 @@ export class Renderer { | |||
| // Line width of a drawn particle. | |||
| particleWidth: 2, | |||
| // Reduce particle count to this fraction (improves FPS). | |||
| particleReduction: 0.1 | |||
| particleReduction: 0.1, | |||
| // Wind velocity at which particle intensity is maximum (m/s). | |||
There was a problem hiding this comment.
It makes sense to have this option configurable, but you also need to add a line after 141 so this gets updated when a user calls start or update:
this.config_.maxWindIntensity = config.maxWindIntensity || this.config_.maxWindIntensity;
Can you also add a line to wind/typedefs.js after line 52 that indicates this option is configurable? Something like:
* maxWindIntensity: (!number=) An optional integer for changing the max wind intensity.
There was a problem hiding this comment.
Ok. Thanks for pointing that out. I'll fix it in a day or two.
|
Apologies for the slow reply, thanks for sending this along. Had just a few comments -- will merge when I hear back. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Making MAX_WIND_INTENSITY configurable allows plotting vectors other than wind of different scale (say sea currents).