Fix #14367: Support polyspace inline suppressions for misra c:20xx rules #8105
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| bool polyspace::isPolyspaceComment(const std::string &comment) | ||
| { | ||
| std::string::size_type pos = 0; | ||
| while (pos < comment.size() && std::strchr("/* ", comment[pos])) |
Check warning
Code scanning / Cppcheck Premium
Condition 'comment.size()-pos<polyspace.size()' is always true Warning
| bool convert(SuppressionList::Suppression &suppr) const; | ||
| }; | ||
|
|
||
| class Parser { |
Check warning
Code scanning / Cppcheck Premium
The class 'Parser' does not declare a constructor although it has private member variables which likely require initialization. Warning
|
| return mPeeked; | ||
| } | ||
|
|
||
| if (mComment.size() >= 2 && (mComment.substr(0, 2) == "/*" || mComment.substr(0, 2) == "//")) { |
There was a problem hiding this comment.
use mComment.compare instead. Hmm.. I think that the mComment.size() >= 2 && is redundant however it's not bad to be explicitly safe.
| bool polyspace::Suppression::convert(SuppressionList::Suppression &suppr) const | ||
| { | ||
| static const std::map<std::string, std::string> map = { | ||
| { "MISRA-C3", "premium-misra-c-2012-" }, |
There was a problem hiding this comment.
if Settings::premiumArgs is nonempty (or contains misra-c-2012) then premium-misra-c-2012- is correct. Otherwise I think we can say misra-c2012- here
| if (comment.size() - pos < polyspace.size()) | ||
| return false; | ||
| return comment.substr(pos, polyspace.size()) == polyspace; |
There was a problem hiding this comment.
Something like this will do the same
| if (comment.size() - pos < polyspace.size()) | |
| return false; | |
| return comment.substr(pos, polyspace.size()) == polyspace; | |
| return comment.compare(pos, polyspace.size(), polyspace, 0, polyspace.size()) == 0; |
| bool polyspace::isPolyspaceComment(const std::string &comment) | ||
| { | ||
| std::string::size_type pos = 0; | ||
| while (pos < comment.size() && std::strchr("/* ", comment[pos])) |
There was a problem hiding this comment.
| while (pos < comment.size() && std::strchr("/* ", comment[pos])) | |
| pos = comment.find_first_not_of("/* "); |
| #include <simplecpp.h> | ||
|
|
There was a problem hiding this comment.
No need for this include as you can just forward declare simplecpp::Token.
|
Should this be behind a flag? Always parsing for something very niche (and premium only?) seems undesired. |
3 participants
No description provided.