Skip to content

Fix #14247 FN returnDanglingLifetime with designated initializer #7937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Nov 9, 2025
Merged

Fix #14247 FN returnDanglingLifetime with designated initializer #7937

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
9adab8a
Skip
web-flow Oct 31, 2025
bb84926
Check for designated initializer
web-flow Nov 1, 2025
7a1a378
Add test
web-flow Nov 2, 2025
fd18797
Add helper
web-flow Nov 2, 2025
152ccdb
Fix
web-flow Nov 4, 2025
59e1c28
Format
web-flow Nov 4, 2025
6e5226f
Format
web-flow Nov 4, 2025
70537aa
Format
web-flow Nov 8, 2025
e8355eb
Add test
web-flow Nov 8, 2025
35fd677
Format
web-flow Nov 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions lib/checkautovariables.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -612,6 +612,8 @@ void CheckAutoVariables::checkVarLifetimeScope(const Token * start, const Token
if (tokvalue->exprId() == tok->exprId() && !(tok->variable() && tok->variable()->isArray()) &&
!astIsContainerView(tok->astParent()))
continue;
if (tokvalue->str() == "=" && Token::simpleMatch(tokvalue->astOperand1(), ".") && !tokvalue->astOperand1()->astOperand2())
tokvalue = tokvalue->astOperand2(); // designated initializer
if ((tokvalue->variable() && !isEscapedReference(tokvalue->variable()) &&
isInScope(tokvalue->variable()->nameToken(), scope)) ||
isDeadTemporary(tokvalue, nullptr, mSettings->library)) {
Expand Down
10 changes: 10 additions & 0 deletions test/testautovariables.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3937,6 +3937,16 @@ class TestAutoVariables : public TestFixture {
ASSERT_EQUALS(
"[test.cpp:6:30] -> [test.cpp:6:30] -> [test.cpp:6:21] -> [test.cpp:5:21] -> [test.cpp:8:12]: (error) Returning object that points to local variable 'a' that will be invalid when returning. [returnDanglingLifetime]\n",
errout_str());

check("struct A { int& x; };\n" // #14247
"A f() {\n"
" int x = 0;\n"
" A a{.x = x};\n"
" return a;\n"
"}\n");
ASSERT_EQUALS(
"[test.cpp:4:12] -> [test.cpp:5:12]: (error) Returning object that will be invalid when returning. [returnDanglingLifetime]\n",
errout_str());
}

void danglingLifetimeInitList() {
Expand Down