Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed emptyString and its remaining usage #7296

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

firewave
Copy link
Collaborator

No description provided.

@firewave
Copy link
Collaborator Author

In my limited local tests I did not see any measurable performance impact. So posting to see if it has any effect in the CI.

@firewave
Copy link
Collaborator Author

The __GLIBC__ check only worked because of the <string>. The backtrace() function is not available on all platforms but I have not figured out how to properly check for it. So just enable it unconditionally of that and wait for some feedback. We probably should split up these preprocessor checks and make them base on the feature/function we use.

@firewave
Copy link
Collaborator Author

With the current changes there is at 11% increase in Tokenizer::simplifyTypedefCpp():

  633,270,864 ( 1.00%)  build/tokenize.cpp:Tokenizer::simplifyTypedefCpp() [/home/runner/work/cppcheck/cppcheck/cppcheck]
  704,783,980 ( 1.11%)  build/tokenize.cpp:Tokenizer::simplifyTypedefCpp() [/home/runner/work/cppcheck/cppcheck/cppcheck]

But that still doesn't account for the total increase:

63,276,354,832 (100.0%)  PROGRAM TOTALS
63,413,640,429 (100.0%)  PROGRAM TOTALS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant