Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/non integer midi #63

Merged
merged 3 commits into from
Feb 18, 2024
Merged

Fix/non integer midi #63

merged 3 commits into from
Feb 18, 2024

Conversation

danigb
Copy link
Owner

@danigb danigb commented Feb 18, 2024

Fixes #61

@danigb danigb merged commit 08cddab into main Feb 18, 2024
1 check passed
@danigb danigb deleted the fix/non-integer-midi branch February 18, 2024 11:58
@tchandelle
Copy link

@danigb Is it possible that this fix is missing from the last version 0.12.2 hosted on NPM?

@danigb
Copy link
Owner Author

danigb commented Mar 30, 2024

Wierd, I've just push another version to npm. If doesn't work, maybe fix was not correct

@tchandelle
Copy link

Ok thanks, now the fix is really included in the packaged version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Non-integer note values do not work with Soundfont class
2 participants