Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theme with attributes rendering #299

Open
wants to merge 12 commits into
base: olio-theme
Choose a base branch
from

Conversation

bniwredyc
Copy link

No description provided.

@coveralls
Copy link

coveralls commented Oct 8, 2016

Coverage Status

Coverage remained the same at 58.211% when pulling 7d63edf on bniwredyc:master into c52a482 on danielgtaylor:olio-theme.

1 similar comment
@coveralls
Copy link

coveralls commented Oct 8, 2016

Coverage Status

Coverage remained the same at 58.211% when pulling 7d63edf on bniwredyc:master into c52a482 on danielgtaylor:olio-theme.

@bniwredyc
Copy link
Author

bniwredyc commented Oct 8, 2016

#103

@jkryanchou
Copy link

👍 Awesome Job ! @bniwredyc We're looking forward to it. Wish it to be merged sooner or later.

@jkryanchou
Copy link

@danielgtaylor Could merge this pull requests soon? We're so looking forward to it that aglio could rendering the attributes.

@runk
Copy link

runk commented Jan 4, 2017

Any updates on this? Missing this feature so much.

@OrangeDog
Copy link

This only appears to work with Attributes in Request sections, not in any other Resource, Action or Payload.
Also, the Show/Hide links on Requests have disappeared entirely.

.npmignore Outdated
@@ -1,6 +1,5 @@
coverage
node_modules
src

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whats the reason behind this being removed?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't remember exactly, but i think I needed it for debugging. Returned it.

@@ -12,7 +12,7 @@ html
a.text-muted.back-to-top(href='#top')
i.fa.fa-toggle-up
|  Back to top
div(class=self.fullWidth ? 'container-fluid' : 'container')
div(class='container-fluid')

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the reason for this being hard-coded to container-fluid now?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I remember I liked it more :) Reverted.

@@ -217,7 +217,7 @@ function init() {
init();

window.onload = function () {
autoCollapse();
// autoCollapse();

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How come this was commented out? Looks like it might be causing the issue with the collapsables that @OrangeDog mentioned.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That string just collapses the left menu on page load. Returned it too for clarity.

@jackbentley
Copy link

This might be better achieved using https://github.com/apiaryio/attributes-kit? I've no idea how to integrate it, however.

@bniwredyc
Copy link
Author

@jackbentley a bird in the hand is worth two in the bush :)

@coveralls
Copy link

coveralls commented Mar 17, 2017

Coverage Status

Coverage remained the same at 58.211% when pulling b106565 on bniwredyc:master into c52a482 on danielgtaylor:olio-theme.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants