Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Breaking: support for Hercule transclusion w/ backwards compatibility (WIP) #241

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Breaking: support for Hercule transclusion w/ backwards compatibility (WIP) #241

wants to merge 1 commit into from

Commits on Nov 29, 2016

  1. Breaking: use Hercule for transclusion 

    Internally Hercule tokenises files into content and link tokens. Only the link portion (excluding the identifying surrounding syntax) is parsed. In the simple case this is simply a file path.In this regard, Aglio syntax permits a strict subset of Hercule's with differing surrounding markers.

Hercule also has built-in circular dependency detection, to prevent the it hanging when provided with bad input.

- Remove: INCLUDE regular expression.
- New: add tokenising regular expression, link match function to extend Hercule's tokeniser with support for existing Aglio syntax.
- Update: compileFile, render to use hercule.transcludeString.
- Beaking: collectPathsSync removed in favour of collectPaths (async).
Hercule is written using streams, which are asynchronous. Without extension of Hercule's sync API (childProcess.spawnSync) which is significantly less performant, collectPathsSync becomes collectPaths (async).
- Docs: updated collectPaths to reflect async.
    James Ramsay committed Nov 29, 2016
    Configuration menu
    Copy the full SHA
    f7d7395 View commit details
    Browse the repository at this point in the history