Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Requirements and Adjusted Playwright configs #7

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

samching
Copy link

@samching samching commented Dec 3, 2022

  1. Added Requirements.txt
  2. Minimal update to readme
  3. Added config to Playwright to avoid having to do playwright install if you have Chrome locally installed.

Note: Deliberately left out fixes included by @zlenner in their pull request to avoid merge conflicts


## Get Started

1. Install Requirements (suggest to do it in `virtualenv` or `conda`)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how about just sticking to venv and may be write instructions for the same? I feel instead of presenting many options, just present one option with all the instructions, so it's easy for people who are out of py ecosystem

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair - although I personally use Conda, so I didn't want to write up something I didn't use / test personally.

Happy to remove that line if you think it's confusing.

@samching samching requested review from vamsipavanmahesh and removed request for vamsipavanmahesh December 4, 2022 16:19
Copy link

@Jcasttrop Jcasttrop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It´s good for me. Don´t u have errors with gcc from go?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants