Repository navigation
Make the default clock colors readable with any accent - #174
Merged
Merged
Conversation
A fresh install, and the System preset, used the Windows accent color for the clock text. Windows allows any shade, so a dark accent in dark mode, like plum on the dark background, or a light accent like yellow in light mode left the text almost invisible. The text is now near-white in dark mode and near-black in light mode, so it's readable with any accent. Existing clocks keep their colors.
The Accent preset always put white text on the accent color, which was hard to read with light accents like yellow or light green. It now picks white or near-black text, whichever stands out more against the accent. Darker accents, including the default Windows blue, keep white text.
The readability tests read this PC's own accent and light or dark mode, so they only covered one case and wouldn't catch a regression elsewhere. The default colors and the Accent preset now come from small functions that take the mode or accent, and the tests check both modes and both a dark and a light accent directly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New installs and the System preset used the Windows accent as the clock's text color. Windows allows any shade, so a dark accent in dark mode, like plum at about 1:1 contrast on the dark background, or a light accent in light mode left the clock nearly invisible.
#F2F2F2on#202020) and near-black in light mode (#212121on#F7F7F7), about 15:1 with any accent. Existing clocks keep their colors.Testing
#D50056on this PC, which is in dark mode) to#F2F2F2on#202020.Worth a look