Skip to content

Support ES7 #110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Support ES7 #110

wants to merge 1 commit into from

Conversation

smn
Copy link

@smn smn commented Mar 17, 2023 •
edited
Loading

ES6 end of life date was the 10th of Feb 2022, this PR has this library at least pass the tests with ES7.

Biggest changes are:

  1. Use ES 7.12.0 in docker-compose & bin/setup
  2. Update the mappings format to remove the nested _doc which was removed in ES7
  3. Update tests to account for string comparison differences and search result count response differences as hits.total is now an object.

This was referenced Mar 17, 2023
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@smn