Telemetry metadata inclusion #108
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Including the start metadata in the stop metadata for
:telemetry.span-wrapped Elasticsearch calls. This makes it so reporters don't have to retain requests for an entire span and can use only the:stopevent to work with metrics.It also locks
sigaws_otp_24, because that was missing previously.For context, see this issue in the Telemetry repo: beam-telemetry/telemetry#112 (comment)
Specifcially, I'm adding these changes because it seems like upstream Telemetry doesn't feel like it's the correct choice to do this automatically. This implies that libraries which implement Telemetry must do this on their own--include StartMetadata along with StopMetadata whenever possible--and, hence, this PR.