Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Browser] New spec compliant parser #12

Draft
wants to merge 7 commits into
base: master
Choose a base branch
from
Draft

Conversation

danfragoso
Copy link
Owner

No description provided.

@danfragoso danfragoso changed the title [Browser] replaced old ketchup regex parser [Browser] New spec compliant parser Aug 13, 2020
@danfragoso danfragoso marked this pull request as draft August 31, 2020 17:02
@Thanson16
Copy link
Contributor

Hello @danfragoso,

I was looking into maybe doing some work on the existing parser (in master), but then saw this draft. Is what is in master right now going to be replaced? If so I'll refrain from working on anything in that area until the new parser is merged in.

Thanks

@danfragoso
Copy link
Owner Author

@Thanson16,
To be honest the code for the spec compliant html parser is already on the master branch, and it can be enabled with the following flags:

"experimentalHTML": false,
"experimentalLayout": false,

The actual parser is built using regex, and is really tricky to build a html5 compliant parser using regex. The spec compliant one is mostly a wrapper around the golang html5 parser. I'm really short on time to work on this project, it was mostly a way to learn how a web browser works, someone posted this on hacker news recently and it got a little bit of attention. If you really want to work on this codebase, tell me where you want to work and I will open some issues and give you any guidance you need to work on this project. What do you think?

@Thanson16
Copy link
Contributor

Ohh, I see.

I can't say I have a ton of free time myself, and only have around a year of experience in software development. So, I don't want you to go out of your way on my behalf or anything - especially if it wasn't really a project you were planning on doing a lot with anyway. But at the same time it looks really cool!

So, if it is something where you'd enjoy getting drive-by contributions from people, not just myself, maybe you could open a few issues with the areas of interest (like you had said), and put something in the README regarding your current status on the project. If I am able to contribute to an area here or there, I'd do so, but it would also open the door to anyone else like me who took an interest to the project and thinks they could do something.

All this as just a humble suggestion. Thank you for your time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants