Skip to content

Conversation

@glostis
Copy link

@glostis glostis commented Jan 6, 2025

Closes #28 by adding a class Neovim which inherits from Vim (since both editors share the same file opening syntax).

@glostis glostis mentioned this pull request Jan 6, 2025
@dandavison
Copy link
Owner

Thanks! Would you mind copying your changes to the other copy of the script at https://github.com/dandavison/open-in-editor/blob/master/OpenInEditor.app/Contents/Resources/script ?

I know... !

@glostis
Copy link
Author

glostis commented Jan 6, 2025

@dandavison sure I can do that, no problem!
As an alternative, did you consider making OpenInEditor.app/Contents/Resources/script a symlink to open-in-editor? That way, they would always be in sync.

@dandavison
Copy link
Owner

As an alternative, did you consider making OpenInEditor.app/Contents/Resources/script a symlink to open-in-editor? That way, they would always be in sync.

I did -- IIRC that doesn't obviously play well with the MacOS app bundle installation at https://github.com/dandavison/open-in-editor?tab=readme-ov-file#macos, I think it would need some sort of build step, but I was trying to keep this all very simple.

@glostis
Copy link
Author

glostis commented Jan 6, 2025

Understood — symlinks can cause some problems at times indeed.

I’ve pushed the change to the other script.

@masonedmison
Copy link

@glostis Have you (or anyone else) tested this change on Mac? I pulled down your branch and rebuilt the application bundle file with platypus as the docs suggest, but opening nvim links doesn't work--the progress bar quickly flashes and disappears, but nothing opens. Note, I'm able to open nvim links (e.g., (nvim:///Users/medmison/file.txt) calling the open-in-editor script directly.

Also, @dandavison would you have happened to test this on Mac? Any help would be appreciated :)

@glostis
Copy link
Author

glostis commented May 23, 2025

@masonedmison I’m afraid I can’t help you, I have only been using this on a Linux machine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

nvim support?

3 participants