Fix idle conversation combat condition - inverted logic and undefined function call #36

Copilot · 2025-10-16T02:45:39Z

Issue

The idle conversation trigger had a critical bug on line 21 that prevented it from working correctly:

local result = cooldown_ready() and queries.is_player_in_combat()

This code had two problems:

Runtime Error: The function queries.is_player_in_combat() doesn't exist in the codebase, causing the mod to fail when attempting to trigger idle conversations
Inverted Logic: Even if the function existed, the condition was backwards - idle conversations would trigger during combat instead of during peaceful moments

Solution

Changed line 21 to use the existing is_in_combat() function with proper logic:

local result = cooldown_ready() and not queries.is_in_combat(queries.get_player())

This fix:

Uses the existing queries.is_in_combat(npc) function from talker_game_queries.script
Passes queries.get_player() as the NPC parameter to check the player's combat status
Adds not to invert the check so idle conversations only trigger when the player is NOT in combat

Validation

The fix follows established patterns in the codebase:

talker_trigger_callout.script (line 31) uses not queries.is_in_combat(npc_obj) for non-combat callouts
talker_trigger_taunt.script (line 25) uses queries.is_in_combat(npc_obj) for combat taunts
Line 36 in the same file also prevents speakers who are in combat from talking

The logic now correctly ensures NPCs only make idle conversation to "pass the time" when both the player and the speaking NPC are not engaged in combat, which aligns with the function's intended purpose.

Fixes the issue reported in #[issue_number] where @Mirrowel identified the inverted condition.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

esm.ubuntu.com
- Triggering command: /usr/lib/apt/methods/https (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Configure Actions setup steps to set up my environment, which run before the firewall is enabled
Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

Original prompt

This section details on the original issue you should resolve

<issue_title>Idle conversation condition reversed?</issue_title>
<issue_description>

TALKER/gamedata/scripts/talker_trigger_idle_conversation.script

Line 21 in 6a009f9

local result = cooldown_ready() and queries.is_player_in_combat()

Shouldn't this be
    local result = cooldown_ready() and not queries.is_player_in_combat()
```</issue_description>

<agent_instructions>Explore and verify if this is an issue and if an action is needed.</agent_instructions>

## Comments on the Issue (you are @copilot in this section)

<comments>
<comment_new><author>@Mirrowel</author><body>
Issues like this make me wish @danclave would allow me to add opencode agent with secrets, so i could just give it this job to work on.</body></comment_new>
</comments>

Fixes #35

💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.

Co-authored-by: Mirrowel <[email protected]>

Mirrowel · 2025-10-16T03:00:20Z

@copilot verify queries.is_player_in_combat() is not a valid call. Explain your position and detail your findings for this point:
Runtime Error: The function queries.is_player_in_combat() doesn't exist in the codebase, causing the mod to fail when attempting to trigger idle conversations

Copilot · 2025-10-16T03:02:58Z

@copilot verify queries.is_player_in_combat() is not a valid call. Explain your position and detail your findings for this point:
Runtime Error: The function queries.is_player_in_combat() doesn't exi...

Verification of `queries.is_player_in_combat()` Not Existing

I've conducted a thorough search of the codebase to verify this claim. Here are my findings:

1. Function Does Not Exist

Searched the entire codebase for is_player_in_combat:

Function definition search: grep -r "function is_player_in_combat" → No results
Function assignment search: grep -r "is_player_in_combat\s*=" → No results
All references: Zero references found except in the buggy code

2. Functions That DO Exist in talker_game_queries.script

The combat-related functions that are actually defined:

Line 186: function get_enemies_fighting_player()
Line 190: function is_enemy_fighting_player(enemy)
Line 195: function is_npc_in_combat(npc)
Line 199: function is_in_combat(npc) ✓ (This is what should be used)

3. Original Buggy Code

From commit 6a009f9, line 21 was:

local result = cooldown_ready() and queries.is_player_in_combat()

4. Why This Would Fail

In Lua, calling a non-existent function results in:

attempt to call a nil value (field 'is_player_in_combat')

Since talker_game_queries is a global module reference (line 9: local queries = talker_game_queries) and has no metatable/__index fallback, accessing queries.is_player_in_combat() would attempt to call nil, causing a runtime error.

5. The Correct Pattern

Line 199-208 shows is_in_combat(npc) accepts any NPC and internally checks if is_player(npc) to handle player combat status appropriately. This is why the fix uses queries.is_in_combat(queries.get_player()).

Mirrowel · 2025-10-16T03:06:03Z

Well, they did decent work on Copilot i guess. I bet it is very good at making shit up.
Have to manually check anyway with no good way to test lmao.

Initial plan

6856e56

Copilot AI assigned Copilot and Mirrowel Oct 16, 2025

Copilot started work on behalf of Mirrowel October 16, 2025 02:46 View session

Fix idle conversation combat condition logic

1055670

Co-authored-by: Mirrowel <[email protected]>

Copilot AI changed the title ~~[WIP] Fix reversed condition for idle conversation~~ Fix idle conversation combat condition - inverted logic and undefined function call Oct 16, 2025

Copilot finished work on behalf of Mirrowel October 16, 2025 02:55

Copilot AI requested a review from Mirrowel October 16, 2025 02:55

Mirrowel marked this pull request as ready for review October 16, 2025 02:58

Copilot started work on behalf of Mirrowel October 16, 2025 03:00 View session

Copilot finished work on behalf of Mirrowel October 16, 2025 03:03

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix idle conversation combat condition - inverted logic and undefined function call #36

Fix idle conversation combat condition - inverted logic and undefined function call #36

Uh oh!

Copilot AI commented Oct 16, 2025 •

edited

Loading

Uh oh!

Mirrowel commented Oct 16, 2025

Uh oh!

Copilot AI commented Oct 16, 2025

Uh oh!

Mirrowel commented Oct 16, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Fix idle conversation combat condition - inverted logic and undefined function call #36

Are you sure you want to change the base?

Fix idle conversation combat condition - inverted logic and undefined function call #36

Uh oh!

Conversation

Copilot AI commented Oct 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Issue

Solution

Validation

I tried to connect to the following addresses, but was blocked by firewall rules:

Uh oh!

Mirrowel commented Oct 16, 2025

Uh oh!

Copilot AI commented Oct 16, 2025

Verification of queries.is_player_in_combat() Not Existing

1. Function Does Not Exist

2. Functions That DO Exist in talker_game_queries.script

3. Original Buggy Code

4. Why This Would Fail

5. The Correct Pattern

Uh oh!

Mirrowel commented Oct 16, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Copilot AI commented Oct 16, 2025 •

edited

Loading

Verification of `queries.is_player_in_combat()` Not Existing