Dev/dominik #35
Dev/dominik #35
Conversation
|
I'm waiting for the green light to review this, as I assume isn't ready, am I correct? |
damian-tomczak
force-pushed
the
dev/dominik
branch
from
cd5f631 to
5ea23c5
Compare
|
is it ready? @Wit111 |
engine/src/core/core.cpp
Outdated
| if (wcstombs_s(&virtualizerNameLen, nullptr, 0, virtualizerName, 0) == 0) | ||
| { | ||
| char* mbstr = new char[virtualizerNameLen]; | ||
| wcstombs_s(&virtualizerNameLen, mbstr, virtualizerNameLen, virtualizerName, virtualizerNameLen); |
There was a problem hiding this comment.
We try to deliver multiplatform code, thus we shouldn't use _s functions
engine/src/core/core.cpp
Outdated
| delete[] mbstr; | ||
| LOGGER_LOG(("Device found "s + virtualizerConvertedName + "Firmware Version: " + std::to_string(info.MajorVersion) + "." + std::to_string(info.MinorVersion)).c_str()); | ||
| } | ||
| else |
There was a problem hiding this comment.
Imo this if condition is redundant
engine/src/core/core.cpp
Outdated
| { | ||
| char* mbstr = new char[virtualizerNameLen]; | ||
| wcstombs_s(&virtualizerNameLen, mbstr, virtualizerNameLen, virtualizerName, virtualizerNameLen); | ||
| std::string virtualizerConvertedName(mbstr); |
There was a problem hiding this comment.
this solution is overcomplicated and in c style
you can just calculate productName c string size then create std::string with the previously gained size to finally use wcstombs and print the filled std string
engine/src/core/core.cpp
Outdated
| @@ -181,6 +216,28 @@ int run(Engine* const engine) try | |||
| isRenderingStarted = true; | |||
| } | |||
| #endif | |||
|
|
|||
| #ifdef CYBSDK_FOUND | |||
| float ring_height = device->GetPlayerHeight(); | |||
There was a problem hiding this comment.
const auto, please use camelCase
engine/src/core/core.cpp
Outdated
|
|
||
| const auto info = device->GetDeviceInfo(); | ||
|
|
||
| const wchar_t* virtName = info.ProductName; |
There was a problem hiding this comment.
this can be also const auto
engine/src/core/core.cpp
Outdated
| std::vector<char> virtBuf(virtNameLen); | ||
| wcstombs(virtBuf.data(), virtName, virtNameLen); | ||
| std::string virtConvertedName(virtBuf.begin(), virtBuf.end()); | ||
| LOGGER_LOG(std::format("Device found {} Firmware Version: {}.{}", virtConvertedName, std::to_string(static_cast<int>(info.MajorVersion)), std::to_string(static_cast<int>(info.MinorVersion))).c_str()); |
There was a problem hiding this comment.
without to_string doesn't work?
engine/src/core/core.cpp
Outdated
| if (movement_speed > 0.f) | ||
| { | ||
| ring_angle *= 2 * std::numbers::pi_v<float>; | ||
| float offsetX = std::sin(ring_angle) * movement_speed * flySpeedMultiplier * deltaTime; |
switched movement to use cyberith virtualizer