Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix invalid error #17

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

omochi
Copy link

@omochi omochi commented Jun 21, 2019

This line of code occurs that returns YES with NSError on error.
It violates cocoa error handling convention.
When we call this method from Swift with Objective-C interop,
this invalid state occurs undeterministic runtime crash.

This PR fix this issue by passing nil to error: for invocation of writeToFile without handling error.

This PR includes #16

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant