Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate pev2 as a component to vizualize execution plan #1431

Merged
merged 1 commit into from
Oct 14, 2024

Conversation

MarionGiusti
Copy link
Contributor

No description provided.

@pirlgon
Copy link
Contributor

pirlgon commented Jul 4, 2024

Could we add some text to explain what this does, what tool is used and maybe a link to PEV2? (not sure for the link)
I find the design a bit too minimalist :) .

@pirlgon
Copy link
Contributor

pirlgon commented Jul 4, 2024

I tried a sample plan coming from explain.dalibo.com (Example 5) and the visualisation seems broken. looks like js or css is missing.

@bersace bersace self-requested a review July 22, 2024 12:13
Copy link
Member

@bersace bersace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

C'est bon pour moi, à terminer avec pierre.

@bersace
Copy link
Member

bersace commented Jul 23, 2024

@marion, pourras-tu ajouter une entrée dans changelog ?

@pgiraud
Copy link
Member

pgiraud commented Jul 23, 2024

@MarionGiusti Can you please rebase your branch? pev2 requires bootstrap to be displayed correctly.

@pgiraud
Copy link
Member

pgiraud commented Sep 4, 2024

Maybe we should tell users what to do. There's no explanation about what this tool does and how to use it. No introduction text, nor placeholders in the textareas. For people who have already used explain.dalibo.com it will be straight forward, for others it will not.

In the pev2 projects, the release process is a bit random and there may be several versions released during one year. How will we make sure that we are up-to-date in temBoard?

ui/package.json Outdated Show resolved Hide resolved
ui/temboardui/static/src/views/Explain.vue Outdated Show resolved Hide resolved
@MarionGiusti MarionGiusti force-pushed the 167_pev2_integration branch 4 times, most recently from 5a7a417 to ce4bed1 Compare October 14, 2024 13:36
@MarionGiusti MarionGiusti merged commit 9ba08cf into dalibo:master Oct 14, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants