Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a "Save statistics" #42

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Add a "Save statistics" #42

wants to merge 9 commits into from

Conversation

platoali
Copy link

@platoali platoali commented Oct 4, 2023

This patch. add "save" option to the speed-type. User have the option to save the statistics automatically, ask before saving or never save.

The are configurations that give user options where to save the records, maximum number of records to save.

I am new to programming and lisp. probably there are rough edges and bugs. Please tell me how to improve this patch.

Copy link
Owner

@dakra dakra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much.

I'll probably take a while to review this as I'm pretty busy atm.
But I had a very brief look and noted some superficial things.

But thanks for trying to tackle this, I wanted to have saved statistics since a while,
see #11

speed-type.el Show resolved Hide resolved
speed-type.el Show resolved Hide resolved
speed-type.el Show resolved Hide resolved
speed-type.el Show resolved Hide resolved
speed-type.el Show resolved Hide resolved
speed-type.el Show resolved Hide resolved
speed-type.el Show resolved Hide resolved
speed-type.el Show resolved Hide resolved
@platoali platoali requested a review from dakra December 17, 2023 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants