Conversation
Previously, `super` calls (both SuperNode and ForwardingSuperNode) were unhandled by the analyzer, causing the return type of `super` to be unknown. This meant any method chain on a super call (e.g. `super.upcase`) would produce a false-positive TypeError, since the receiver type could not be resolved. This change: - Extracts the superclass name from `class Child < Parent` declarations and records it in the class scope - Adds `current_method_name()` and `current_superclass()` helpers to ScopeManager for resolving super calls in context - Introduces `super_calls.rs` to handle SuperNode and ForwardingSuperNode by dispatching to the parent class's same-named method - Refactors argument collection into a shared `collect_arguments()` helper reused by both regular method calls and super calls Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
supercalls (SuperNodeandForwardingSuperNode), which were previously unhandled and caused false-positive TypeErrors on method chains likesuper.upcaseclass Child < Parentdeclarations into the class scopesuper_calls.rsas a dedicated handler and refactor argument collection into a sharedcollect_arguments()helper reused by both regular and super callscurrent_method_name()/current_superclass()scope helpers for resolving super contextTest plan
ScopeManager#current_method_nameand#current_superclass(including nested block scenarios)Animals::Pet), edge cases (super outside method, super without superclass)super.even?on String)🤖 Generated with Claude Code