Skip to content

mobile: daimo pay deposit webview #1395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

andrewliu08
Copy link
Member

@andrewliu08 andrewliu08 commented Apr 19, 2025

Screen.Recording.2025-04-21.at.11.35.48.AM.mov

@andrewliu08 andrewliu08 requested a review from dcposch April 19, 2025 03:31
Copy link

vercel bot commented Apr 19, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
daimo-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 21, 2025 6:54pm

const [showDaimoPay, setShowDaimoPay] = useState(false);
const nav = useNav();

// Automatically close Daimo Pay webview when the user navigates away.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

const baseUrl = "http://localhost:3005/embed";
const params = new URLSearchParams({
toAddress: account.address,
refundAddress: "0xEEee8B1371f1664b7C2A8c111D6062b6576fA6f0", // daimo.eth
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

might be worth making a dedicated one

const handleMessage = useCallback(
(event: WebViewMessageEvent) => {
try {
const data = JSON.parse(event.nativeEvent.data);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

recommend logging data here

Copy link
Member

@dcposch dcposch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

  • fix lint
  • paste in a screenshot of the new deposit page

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants