fix: use shared and content title and image for post types #2477
+208
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
capJavert
requested review from
rebelchris,
omBratteng,
ilasw,
sshanzel,
nensidosari and
AmarTrebinjac
capJavert
commented
Nov 21, 2024
Comment on lines
+604
to
+608
| export const findPostImageFromContent = ({ | ||
| post, | ||
| }: { | ||
| post: Pick<FreeformPost, 'content'>; | ||
| }): string | undefined => { |
There was a problem hiding this comment.
get first post image from content
capJavert
commented
Nov 21, 2024
Comment on lines
+174
to
+176
| if (depth > maxDepth) { | ||
| return undefined; | ||
| } |
There was a problem hiding this comment.
since this is recursive (due to markdown structure being tree) I added depth so we don't go too deep and affect performance.
By default its 2 level, which should be more then enough for markdown content we can create in our editor.
capJavert
changed the title
rebelchris
approved these changes
Nov 22, 2024
| @@ -88,8 +93,13 @@ const getPostsTemplateData = ({ | |||
| const summary = post.summary || ''; | |||
|
|
|||
| return { | |||
| post_title: post.title, | |||
| post_image: mapCloudinaryUrl(post.image || pickImageUrl(post)), | |||
| post_title: post.title || post.sharedPostTitle, | |||
There was a problem hiding this comment.
I thought I already added this, but maybe it was for another email.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes dailydotdev/daily#1600