Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Voice in scenario 48 and 51, fix philips hue integration #2105

Closed
wants to merge 0 commits into from

Conversation

Massimo53
Copy link
Contributor

I didn't mean to include philips hue in this to keep to it separate from scenario fixes, but I can't take it out.

@aBlueShadow
Copy link
Contributor

Pull requests compare changes between two branches across two repositories.
So if you want to keep changes seperate, you have to create different branches. Which does not necessary mean you have to do it now, it might be that daid is okay with it in this instance. Just something to be considered for the future.

@daid
Copy link
Owner

daid commented May 14, 2024

Sadly, the hue changes look like a work and progress and not something ready for merging.

@aBlueShadow
Copy link
Contributor

That's unfortunate

you now have several options @Massimo53 :

a) make sure you have a local copy of the hue file, then undo the changes of that file in your online repository. This might look a bit irritating in the commit history, but will do the trick.
b) make sure to have local copies of all three changed files, delete your EE fork, then make a new one. As your fork just had 3 commits and no other branches yet, that would be a viable option. This will reset all your changes. Then make sure to make branches this time. In this branches, you can change the files and make Pull requests.
c) you can also undo your last commit, but I think that only works if you have git setup locally.

If you are new to git and github, I would recommend a) or b)

@daid
Copy link
Owner

daid commented May 15, 2024

(actually, you could just make a branch from commit 7a4212b and submit that)

@aBlueShadow
Copy link
Contributor

aBlueShadow commented May 15, 2024

Or that :-)
That would fall in the same category as c) though, at least I could not find a way to do this in the web interface, it seems you only can branch off from another branch on the web.

@Massimo53
Copy link
Contributor Author

no problem, it was a quick and dirty because I didn't have time to set up my form properly. I'll resubmit once I have it set up.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants