Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve resolveClient for DEV #998

Draft
wants to merge 24 commits into
base: main
Choose a base branch
from

Conversation

dai-shi
Copy link
Owner

@dai-shi dai-shi commented Nov 11, 2024

close #982

Copy link

vercel bot commented Nov 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
waku ✅ Ready (Inspect) Visit Preview Nov 18, 2024 9:41am

Copy link

codesandbox-ci bot commented Nov 11, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@dai-shi dai-shi mentioned this pull request Nov 13, 2024
87 tasks
Comment on lines +688 to +692
const resolved = await this.resolve(id, importer, options);
let srcId =
importer && (id.startsWith('./') || id.startsWith('../'))
? joinPath('/@fs', importer.split('?')[0]!, '..', id)
: id;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this might be the issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Cannot use import statement outside a module" error in dev server with react-error-boundary
2 participants