Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(stylex): revert to vite-plugin-stylex-dev for now #1106

Merged
merged 1 commit into from
Dec 29, 2024
+97 −85
Merged

fix(stylex): revert to vite-plugin-stylex-dev for now #1106

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions examples/37_css/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,9 +20,9 @@
"devDependencies": {
"@types/react": "19.0.2",
"@types/react-dom": "19.0.2",
"@vanilla-extract/vite-plugin": "4.0.18",
"@vanilla-extract/vite-plugin": "4.0.19",
"typescript": "5.7.2",
"vite": "6.0.6",
"vite-plugin-stylex": "0.13.0"
"vite-plugin-stylex-dev": "0.7.5"
}
}
2 changes: 0 additions & 2 deletions examples/37_css/src/components/app.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
@stylex stylesheet;

h1 {
color: red;
}
3 changes: 3 additions & 0 deletions examples/37_css/src/components/layout.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,9 @@ import type { ReactNode } from 'react';

import './layout.styles.css';

// eslint-disable-next-line import/no-unresolved
import '@stylex-dev.css';

const Layout = ({ children }: { children: ReactNode }) => {
return (
<html>
Expand Down
6 changes: 3 additions & 3 deletions examples/37_css/waku.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,21 +1,21 @@
import { defineConfig } from 'waku/config';
import { vanillaExtractPlugin } from '@vanilla-extract/vite-plugin';
import stylexPlugin from 'vite-plugin-stylex';
import { stylex } from 'vite-plugin-stylex-dev';

export default defineConfig({
unstable_viteConfigs: {
common: () => ({
plugins: [
{
name: 'hack-css-plugin-needed-for-stylex-FIXME',
name: 'hack-css-plugin-needed-for-stylex-dev-FIXME',
resolveId(id: string) {
if (id.endsWith('.css') && !id.endsWith('.vanilla.css')) {
return id;
}
},
},
vanillaExtractPlugin(),
stylexPlugin() as any, // FIXME no-any
stylex(),
],
}),
},
Expand Down
Loading
Loading