Add push behavior to useQueryPersistedState
#28302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for dagit-core-storybook ready! ✅ Preview Built with commit 69f5375. |
hellendag
approved these changes
Mar 6, 2025
Comment on lines
122
to
124
| history.push( | ||
| `${history.location.pathname}?${qs.stringify(next, {arrayFormat: 'brackets'})}`, | ||
| ); |
There was a problem hiding this comment.
Build the string once prior to the conditionals so that if something in the callsite has to change, we don't accidentally overlook one?
bengotow
approved these changes
Mar 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
Add push behavior so that we can use this for selection syntax to allow back to go to the previous syntax.
How I Tested These Changes
jest + local testing