[compute logs] standardize on fetching 1MB at a time #28101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for dagit-core-storybook ready! ✅ Preview Built with commit 928e9a5. |
prha
approved these changes
Feb 27, 2025
alangenfeld
deleted the
al/02-27-_compute_logs_standardize_on_fetching_1mb_at_a_time
branch
jmsanders
pushed a commit
that referenced
this pull request
Feb 28, 2025
get websocket and polling versions aligned with a smaller chunk size ## How I Tested These Changes load large compute logs with websockets on and off (cherry picked from commit b0ac0ea)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
get websocket and polling versions aligned with a smaller chunk size
How I Tested These Changes
load large compute logs with websockets on and off