[ui] Show warning on partitions that did not materialize due to canceled runs #28045
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
|
Deploy preview for dagit-core-storybook ready! ✅ Preview Built with commit 82e3b46. |
salazarm
approved these changes
Feb 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
It is confusing for partitions that were not materialized due to canceled runs do not show any messaging indicating that a failure or cancellation occurred on the asset partition detail page.
This is because we only show the banner if the run failed. Update this to show a banner if it was canceled as well. Use a "warning" intent for the cancellation banner, to help visually distinguish it from the failed run.
Also updated the copy a bit, since it's the runs that fail or are canceled.
How I Tested These Changes
View partition that failed to materialize due to cancellation. Verify that the yellow banner appears.
View partition that failed to materialize due to failed run. Verify that the red banner appears.
Changelog
[ui] For asset partitions that fail to materialize due to a run cancellation, show this information on the asset partition detail page.