Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] add generated code examples to gitignore #27830

Merged
merged 2 commits into from
Feb 13, 2025

Conversation

cmpadden
Copy link
Contributor

@cmpadden cmpadden commented Feb 13, 2025

Summary & Motivation

  • We should not need to include this in version control, since it will be generated at build time, and also at runtime during development.
  • Removing this reduces the mental load of users having to think about if they need to check in this change.

How I Tested These Changes

Changelog

NOCHANGELOG

@cmpadden cmpadden requested a review from neverett as a code owner February 13, 2025 15:25
Copy link

github-actions bot commented Feb 13, 2025

Deploy preview for dagster-docs ready!

Preview available at https://dagster-docs-f27c8k0b7-elementl.vercel.app

Direct link to changed pages:

@cmpadden cmpadden force-pushed the colton/docs-ignore-code-examples branch from f22a6fa to 705f163 Compare February 13, 2025 19:46
@cmpadden cmpadden merged commit 97ebca3 into master Feb 13, 2025
7 checks passed
@cmpadden cmpadden deleted the colton/docs-ignore-code-examples branch February 13, 2025 19:59
braunjj pushed a commit that referenced this pull request Feb 14, 2025
## Summary & Motivation

* We should not need to include this in version control, since it will
be generated at build time, and also at runtime during development.
* Removing this reduces the mental load of users having to think about
if they need to check in this change.

## How I Tested These Changes

## Changelog

NOCHANGELOG
brentjericho pushed a commit to brentjericho/dagster that referenced this pull request Feb 21, 2025
## Summary & Motivation

* We should not need to include this in version control, since it will
be generated at build time, and also at runtime during development.
* Removing this reduces the mental load of users having to think about
if they need to check in this change.

## How I Tested These Changes

## Changelog

NOCHANGELOG
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants