Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test to stop a future nested config regression #27343

Merged
merged 6 commits into from
Jan 28, 2025

Conversation

deepyaman
Copy link
Contributor

@deepyaman deepyaman commented Jan 24, 2025

Summary & Motivation

Guard against regression of #27223

How I Tested These Changes

Local run + BK

@deepyaman deepyaman marked this pull request as ready for review January 24, 2025 07:29
Copy link
Contributor

@OwenKephart OwenKephart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for adding!

@deepyaman deepyaman force-pushed the deepyaman/test/nested-config-configured-at-launch branch 2 times, most recently from 4f169e1 to 6c035bf Compare January 25, 2025 00:21
@deepyaman deepyaman force-pushed the deepyaman/test/nested-config-configured-at-launch branch from 6c035bf to 5b8ebd5 Compare January 27, 2025 21:33
@deepyaman deepyaman force-pushed the deepyaman/test/nested-config-configured-at-launch branch from 5b8ebd5 to 332af21 Compare January 27, 2025 23:51
@deepyaman deepyaman merged commit 742ac38 into master Jan 28, 2025
4 of 5 checks passed
@deepyaman deepyaman deleted the deepyaman/test/nested-config-configured-at-launch branch January 28, 2025 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants