[3/n][Selection syntax] Add stubs to allow Cloud to extend selection syntax functionality. #27184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
salazarm
requested review from
bengotow,
hellendag,
benpankow and
clairelin135
|
Deploy preview for dagit-core-storybook ready! ✅ Preview Built with commit 97fb151. |
…astic-search-filters-in-selection-syntax
hellendag
approved these changes
Jan 21, 2025
Comment on lines
+97
to
+102
| const assetNames = Array.from(assetNamesSet); | ||
| const tagNames = Array.from(tagNamesSet); | ||
| const owners = Array.from(ownersSet); | ||
| const groups = Array.from(groupsSet); | ||
| const kinds = Array.from(kindsSet); | ||
| const codeLocations = Array.from(codeLocationSet); |
There was a problem hiding this comment.
Worth sorting these in any way?
There was a problem hiding this comment.
yeah probably, let me add that
There was a problem hiding this comment.
will add in a follow-up PR so that I can unbreak buildkite
salazarm
deleted the
salazarm/elastic-search-filters-in-selection-syntax
branch
marijncv
pushed a commit
to marijncv/dagster
that referenced
this pull request
Jan 21, 2025
…syntax functionality. (dagster-io#27184) ## Summary & Motivation - Add `useAssetGraphSupplementaryData` so that Cloud can query for extra data to support the filtering - Feed that data all the way through to the visitor that does the filtering. Don't do anything with it in the OSS visitor, Cloud will use it in its visitor though to do that additional filtering. ## How I Tested These Changes Manual testing + relying on existing jest tests <img width="650" alt="Screenshot 2025-01-16 at 6 25 14 PM" src="https://github.com/user-attachments/assets/a5bbf8d7-c4f0-4d8b-bd53-0debdd3b794f" />
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
useAssetGraphSupplementaryDataso that Cloud can query for extra data to support the filteringHow I Tested These Changes
Manual testing + relying on existing jest tests