[dagster-dbt] Spec-ify dbt cloud integration #26662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
OwenKephart
force-pushed
the
12-19-_dagster-dbt_refactor_clean_up_multi-asset_creation
branch
from
045075a to
d07cd21
Compare
OwenKephart
force-pushed
the
12-21-_dagster-dbt_spec-ify_dbt_cloud_integration
branch
from
4599035 to
cd1dfdc
Compare
OwenKephart
force-pushed
the
12-19-_dagster-dbt_refactor_clean_up_multi-asset_creation
branch
from
d07cd21 to
d74987c
Compare
OwenKephart
force-pushed
the
12-21-_dagster-dbt_spec-ify_dbt_cloud_integration
branch
2 times, most recently
from
5f32d81 to
c10af5c
Compare
dpeng817
reviewed
Dec 23, 2024
| @@ -890,137 +881,6 @@ def _validate_asset_keys( | |||
| ) | |||
|
|
|||
|
|
|||
| def get_asset_deps( | |||
dpeng817
reviewed
Dec 23, 2024
| deps=dbt_dependencies, | ||
| # TODO: In the future, allow the IO manager to be specified. | ||
| io_manager_key=None, | ||
| # generate specs for each executed node |
dpeng817
reviewed
Dec 23, 2024
| manifest=None, | ||
| select=" ".join( | ||
| f"fqn:{'.'.join(dbt_nodes[unique_id]['fqn'])}" for unique_id in executed_unique_ids | ||
| ), | ||
| ) | ||
|
|
||
| return AssetsDefinitionCacheableData( | ||
| # TODO: In the future, we should allow additional upstream assets to be specified. |
There was a problem hiding this comment.
while we're here can we get rid of this / make a linear ticket (but I think this is possible via map asset specs now, so not really necessary
dpeng817
reviewed
Dec 23, 2024
| keys_by_output_name={ | ||
| output_name: asset_key for asset_key, (output_name, _) in asset_outs.items() | ||
| }, | ||
| keys_by_output_name={spec.key.to_python_identifier(): spec.key for spec in specs}, |
There was a problem hiding this comment.
somewhat surprised we don't also have to include checks here, but it doesn't look like we did before either
dpeng817
approved these changes
Dec 23, 2024
OwenKephart
force-pushed
the
12-19-_dagster-dbt_refactor_clean_up_multi-asset_creation
branch
from
d74987c to
35c9420
Compare
OwenKephart
force-pushed
the
12-21-_dagster-dbt_spec-ify_dbt_cloud_integration
branch
from
c10af5c to
be8c8bb
Compare
OwenKephart
changed the base branch from
12-19-_dagster-dbt_refactor_clean_up_multi-asset_creation
to
graphite-base/26662
OwenKephart
force-pushed
the
12-21-_dagster-dbt_spec-ify_dbt_cloud_integration
branch
from
be8c8bb to
ca1bbf9
Compare
OwenKephart
deleted the
12-21-_dagster-dbt_spec-ify_dbt_cloud_integration
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
Updates the dbt cloud integration to be more spec-native, taking advantage of existing utilities for generating specs from a dbt project.
This results in the ability to delete a large amount of code.
How I Tested These Changes
Changelog
NOCHANGELOG