add grpcio 1.57.0 pin to provided helm chart images #26630
+8
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Attempt to resolve reported memory leak versions with . Apparently the underlying issue is also resolved in python 3.13, so once we officially support that in dagster, we could potentially move these images to 3.13 and remove this. Test Plan: Deploy the helm chart locally with these built images Changelog: Added a pin to the grpcio version used by the Dagster Helm chart daemon and webserver images, to a version that has been reported to avoid memory leaks.
danielgafni
approved these changes
Dec 20, 2024
alangenfeld
reviewed
Dec 20, 2024
| @@ -13,4 +13,5 @@ RUN python -m uv pip install \ | |||
| -e dagster-k8s \ | |||
| -e dagster-celery[flower,redis,kubernetes] \ | |||
| -e dagster-celery-k8s \ | |||
| -e dagster-webserver | |||
| -e dagster-webserver \ | |||
| grpcio==1.57.0 # workaround for reported memmory leak issues with later versions of grpc | |||
There was a problem hiding this comment.
something in the comment / link to make it easier for future person to know if its safe to remove
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Attempt to resolve reported memory leak versions with . Apparently the underlying issue is also resolved in python 3.13, so once we officially support that in dagster, we could potentially move these images to 3.13 and remove this.
Test Plan:
Deploy the helm chart locally with these built images
Changelog:
Added a pin to the grpcio version used by the Dagster Helm chart daemon and webserver images, to a version that has been reported to avoid memory leaks.
Summary & Motivation
How I Tested These Changes
Changelog