[components] Rename build_defs_from_toplevel_components_folder to build_component_defs and make it less magical #26618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
schrockn
changed the title
OwenKephart
approved these changes
Dec 20, 2024
| def build_defs_from_toplevel_components_folder( | ||
| path: Path, | ||
| def build_component_defs( | ||
| code_location_path: Path, |
There was a problem hiding this comment.
code_location_path -> code_location_root to match docstring (could be swayed either direction but somewhat prefer code_location_root)
schrockn
force-pushed
the
schrockn/make-components-loading-less-magical
branch
from
cdc62de to
ef4ddd1
Compare
Merge activity
|
schrockn
force-pushed
the
schrockn/make-components-loading-less-magical
branch
from
ef4ddd1 to
7c83f99
Compare
…defs and make it less magical
schrockn
force-pushed
the
schrockn/make-components-loading-less-magical
branch
from
7c83f99 to
cecbfdb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
Does a couple things
build_defs_from_toplevel_components_foldertobuild_component_defsdagster_componentsHow I Tested These Changes
Generated empty code location from scaffolding and loaded it.
Changelog
BK