-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[components] Move dagster-components test component lib to dagster_components.lib.test #26611
[components] Move dagster-components test component lib to dagster_components.lib.test #26611
Conversation
8db3359
to
75df631
Compare
75df631
to
6ca4051
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also ensures these components are accessible whether from a published dagster-components
Why is this desirable?
…mponents.lib.test
6ca4051
to
ed129b8
Compare
It is useful for testing. Currently there are some annoyances with some tests that construct a code location without an editable install, and I think this will prove useful in manual testing in the future. But the primary reason for this is to simplify the entry point loading code path by removing the need to check for the separate package |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Per discussion not sure this is where we end up landing, but it is incrementally better.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Per discussion the longer term solution is to publish a standalone test package.
Summary & Motivation
Move the
dagster-components
test component library fromdagster_components_tests.lib
todagster_components.lib.test
. This lets us simplify entry point loading code (eliminate call toensure_dagster_components_tests_import
) and also ensures these components are accessible whether from a publisheddagster-components
or local (we don't include our test packages in published distributions as a rule)How I Tested These Changes
Existing test suite.