Add error boundaries to prevent write stream errors in InstigationLogger from failing schedule/sensor ticks #26609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gibsondan
force-pushed
the
sensorerrorboundary
branch
from
a8833f3 to
94f89ac
Compare
gibsondan
changed the title
gibsondan
changed the title
…eam in InstigationLogger This prevents issues with the compute log manager from failing a schedule or sensor tick in which the logging call is happening.
gibsondan
force-pushed
the
sensorerrorboundary
branch
from
94f89ac to
2eaa878
Compare
alangenfeld
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents issues with the compute log manager from failing a schedule or sensor tick in which the logging call is happening.
Summary & Motivation
How I Tested These Changes
BK
Changelog
Exceptions that are raised when a schedule or sensor are writing logs will now write an error message to stdout instead of failing the tick.