[dagster-databricks] Fix Cluster Drive Log Root Error when no extras provided for pipe #26592
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
seems reasonable to me. Just want to get @danielgafni 's sign off in case there is an underlying issue here where extras isn't getting set when we expect it to be set
|
In the meantime, @GBBBAS can you run |
jamiedemaria
requested changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
Addresses bug #26434 where an error is thrown for any Databricks Pipes where extras have not been provided for the pipe.
Update checks if extras is available in params first to prevent the bug from being thrown
How I Tested These Changes
Changelog