[1.9] Remove Python 3.8 Support #25523

OwenKephart · 2024-10-24T20:09:39Z

Summary & Motivation

Remove support for Python 3.8

How I Tested These Changes

Changelog

Dagster no longer supports Python 3.8, which hit EOL on 2024-10-07.

OwenKephart · 2024-10-24T20:10:44Z

[1.9] Remove Python 3.8 Support #25523 👈
master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @OwenKephart and the rest of your teammates on Graphite

cmpadden

Couple more references we'll prob wanna get:

scripts/templates_create_dagster_package/setup.py.tmpl
31:        "Programming Language :: Python :: 3.8",

content/dagster-plus/deployment/serverless.mdx
167:The default version of Python for Serverless deployments is Python 3.8. Versions 3.9 through 3.12 are also supported. You can specify the version you want by updating your GitHub workflow or using the `--python-version` command line argument:
193:1. The standard Python "slim" [Docker image](https://hub.docker.com/\_/python), such as `python:3.8-slim` is used as the base.

docs-beta/docs/dagster-plus/deployment/serverless/runtime-environment.md
17:The default Python version for Dagster+ Serverless is Python 3.8. Python versions 3.9 through 3.12 are also supported. You can specify the Python version you want to use in your GitHub or GitLab workflow, or by using the `dagster-cloud` CLI.

content/concepts/dagster-pipes/aws-glue.mdx
31:  - An AWS Glue job with a Python 3.8+ runtime environment

next/markdoc/partials/DagsterVersion.md
1:Dagster supports Python 3.8 through 3.12.

dagster-university/pages/dagster-essentials/lesson-5/whats-a-code-location.md
66:- Python version (ex., legacy code using Python 3.8 and newer Python 3.11 code locations)

dagster-university/pages/dagster-dbt/lesson-7/5-preparing-for-a-successful-run.md
102:  PYTHON_VERSION: '3.8'

dagster-university/pages/dagster-essentials/lesson-2/requirements-and-installation.md
11:- **To install Python**. Dagster supports Python 3.8 through 3.12.

next/components/mdx/includes/dagster/DagsterVersion.mdx
1:Dagster supports Python 3.8 through 3.12.

docs-beta/docs/getting-started/installation.md
12:- To install Python 3.8 or higher. **Python 3.11 is recommended**.

docs-beta/docs/getting-started/quickstart.md
30:- Python 3.8+ installed on your system. Refer to the [Installation guide](/getting-started/installation) for information.

github-actions · 2024-10-24T20:19:14Z

Deploy preview for dagster-docs ready!

Preview available at https://dagster-docs-1dld4iegw-elementl.vercel.app
https://10-24--1-9-remove-python-3-8-support.dagster.dagster-docs.io

Direct link to changed pages:

https://dagster-docs-1dld4iegw-elementl.vercel.app
https://10-24--1-9-remove-python-3-8-support.dagster.dagster-docs.io/concepts/dagster-pipes/aws-glue
https://dagster-docs-1dld4iegw-elementl.vercel.app
https://10-24--1-9-remove-python-3-8-support.dagster.dagster-docs.io/dagster-plus/deployment/serverless
docs/next/components/mdx/includes/dagster/DagsterVersion

github-actions · 2024-10-24T20:22:02Z

Deploy preview for dagster-docs-beta ready!

Preview available at https://dagster-docs-beta-kdb5ug6xm-elementl.vercel.app

Direct link to changed pages:

cmpadden · 2024-10-24T20:26:17Z

Oh gosh, that was a bit of a rabbit hole. But this might be relevant too, @OwenKephart .

pyproject.toml
52:pythonVersion = "3.8"

integration_tests/test_suites/backcompat-test-suite/webserver_service/Dockerfile_user_code_release
1:FROM python:3.8-slim

integration_tests/test_suites/backcompat-test-suite/webserver_service/Dockerfile_webserver_source
1:FROM python:3.8-slim

integration_tests/test_suites/backcompat-test-suite/webserver_service/Dockerfile_webserver_release
1:FROM python:3.8-slim

integration_tests/test_suites/backcompat-test-suite/webserver_service/Dockerfile_user_code_source
1:FROM python:3.8-slim

python_modules/dagster/README.md
73:Dagster is available on PyPI and officially supports Python 3.8 through Python 3.12.

python_modules/automation/automation/docker/images/buildkite-build-test-project-image/versions.yaml
1:"3.8":
3:    BASE_IMAGE: python:3.8-slim

python_modules/automation/automation/docker/images/test-project-base/versions.yaml
1:"3.8":
3:    BASE_IMAGE: python:3.8-slim

python_modules/dagster/dagster/_record/__init__.py
65:                # This workaround only seems needed for py3.8

python_modules/automation/automation/docker/images/buildkite-test/versions.yaml
1:"3.8":
3:    BASE_IMAGE: python:3.8-slim

python_modules/automation/automation/docker/images/buildkite-integration-windows/versions.yaml
1:"3.8":
3:    BASE_IMAGE: python:3.8-windowsservercore-1809

python_modules/dagster/dagster/_generate/templates/CODE_LOCATION_NAME_PLACEHOLDER/pyproject.toml.tmpl
6:requires-python = ">=3.8,<3.13"

examples/docs_beta_snippets/docs_beta_snippets_tests/test_integration_files_load.py
23:    # FIXME: this breaks on py3.8 and seems related to the non-dagster dependencies

examples/docs_beta_snippets/docs_beta_snippets/dagster-plus/deployment/serverless/runtime-environment/gitlab_disable_pex.yaml
7:  PYTHON_VERSION: '3.8'

python_modules/libraries/dagster-celery/setup.py
39:        "importlib_metadata<5.0.0; python_version<'3.8'",  # https://github.com/celery/celery/issues/7783

python_modules/dagster/dagster/_utils/__init__.py
221:    """Backport of Python 3.8 os.path.isfile behavior.
223:    This is intended to backport https://docs.python.org/dev/whatsnew/3.8.html#os-path. I'm not
367:    # https://docs.python.org/3.8/library/tempfile.html#tempfile.NamedTemporaryFile


python_modules/dagster/dagster_tests/core_tests/resource_tests/pythonic_resources/test_general_pythonic_resources.py
103:@pytest.mark.skipif(sys.version_info < (3, 8), reason="requires python3.8")

python_modules/dagster/dagster_tests/core_tests/pythonic_config_tests/test_basic_pythonic_config.py
446:@pytest.mark.skipif(sys.version_info < (3, 8), reason="requires python3.8")

python_modules/dagster/dagster_tests/storage_tests/test_upath_io_manager.py
516:requires_python38 = pytest.mark.skipif(sys.version_info < (3, 8), reason="requires python3.8")

OwenKephart · 2024-10-24T20:33:17Z

@cmpadden updated

github-actions · 2024-10-24T20:35:09Z

Deploy preview for dagster-university ready!

✅ Preview
https://dagster-university-34a9nepbm-elementl.vercel.app
https://10-24--1-9-remove-python-3-8-support.dagster-university.dagster-docs.io

Built with commit 1686fab.
This pull request is being automatically deployed with vercel-action

OwenKephart · 2024-10-24T20:36:44Z

oops didn't update with your new stuff

OwenKephart · 2024-10-24T20:47:40Z

@cmpadden updated for real -- tried to avoid making any actual code changes, and some of those reference behavior that exists as backcompat for py3.8, so i left them in.

could consider a second round of deletions after this to clean that up

cmpadden · 2024-10-24T20:50:56Z

@cmpadden updated for real -- tried to avoid making any actual code changes, and some of those reference behavior that exists as backcompat for py3.8, so i left them in.

could consider a second round of deletions after this to clean that up

Sweet, confirmed the instances that I found no longer exist.

Will probably defer approval to @alangenfeld or @gibsondan, since this is a pretty big one.

...ation_tests/test_suites/backcompat-test-suite/webserver_service/Dockerfile_user_code_release

alangenfeld · 2024-10-24T21:25:35Z

...modules/automation/automation/docker/images/buildkite-build-test-project-image/versions.yaml

@@ -1,3 +1,3 @@
-"3.8":
+"3.9":


dagster-image build-all --name buildkite-build-test-project-image --dagster-version 0.0.1 dagster-image push-all --name buildkite-build-test-project-image

alangenfeld

bye

update

## Summary & Motivation Remove support for Python 3.8 ## How I Tested These Changes ## Changelog Dagster no longer supports Python 3.8, which hit EOL on 2024-10-07.

OwenKephart force-pushed the 10-24-_1.9_remove_python_3.8_support branch from 3e129aa to e858278 Compare October 24, 2024 20:10

graphite-app bot requested review from PedramNavid and cmpadden October 24, 2024 20:10

graphite-app bot added the area: docs Related to documentation in general label Oct 24, 2024

graphite-app bot requested a review from C00ldudeNoonan October 24, 2024 20:10

cmpadden previously requested changes Oct 24, 2024

View reviewed changes

OwenKephart force-pushed the 10-24-_1.9_remove_python_3.8_support branch from e858278 to 2526c43 Compare October 24, 2024 20:33

graphite-app bot added the area: dagster-university Related to Dagster University label Oct 24, 2024

graphite-app bot requested a review from cmpadden October 24, 2024 20:33

alangenfeld mentioned this pull request Oct 24, 2024

drop python 3.8 support #25517

Closed

OwenKephart force-pushed the 10-24-_1.9_remove_python_3.8_support branch 2 times, most recently from bb0e857 to e9dd138 Compare October 24, 2024 20:46

cmpadden requested review from gibsondan and alangenfeld October 24, 2024 20:51

OwenKephart force-pushed the 10-24-_1.9_remove_python_3.8_support branch from e9dd138 to ea47f57 Compare October 24, 2024 20:53

alangenfeld reviewed Oct 24, 2024

View reviewed changes

...ation_tests/test_suites/backcompat-test-suite/webserver_service/Dockerfile_user_code_release Outdated Show resolved Hide resolved

alangenfeld reviewed Oct 24, 2024

View reviewed changes

cmpadden removed the area: dagster-university Related to Dagster University label Oct 24, 2024

OwenKephart force-pushed the 10-24-_1.9_remove_python_3.8_support branch 3 times, most recently from e7c4bf6 to 48900f1 Compare October 28, 2024 16:43

OwenKephart force-pushed the 10-24-_1.9_remove_python_3.8_support branch 5 times, most recently from 29d3a15 to 346d2ed Compare October 28, 2024 17:56

[1.9] Remove Python 3.8 Support

1686fab

OwenKephart force-pushed the 10-24-_1.9_remove_python_3.8_support branch from 346d2ed to 1686fab Compare October 28, 2024 18:20

OwenKephart requested a review from alangenfeld October 28, 2024 19:04

alangenfeld approved these changes Oct 28, 2024

View reviewed changes

OwenKephart merged commit 84305e0 into master Oct 28, 2024
5 checks passed

OwenKephart deleted the 10-24-_1.9_remove_python_3.8_support branch October 28, 2024 21:10

OwenKephart added a commit that referenced this pull request Oct 28, 2024

[1.9] Remove Python 3.8 Support (#25523)

6227591

## Summary & Motivation Remove support for Python 3.8 ## How I Tested These Changes ## Changelog Dagster no longer supports Python 3.8, which hit EOL on 2024-10-07.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[1.9] Remove Python 3.8 Support #25523

[1.9] Remove Python 3.8 Support #25523

OwenKephart commented Oct 24, 2024

OwenKephart commented Oct 24, 2024 •

edited

Loading

cmpadden left a comment

github-actions bot commented Oct 24, 2024 •

edited

Loading

github-actions bot commented Oct 24, 2024 •

edited

Loading

cmpadden commented Oct 24, 2024

OwenKephart commented Oct 24, 2024

github-actions bot commented Oct 24, 2024 •

edited

Loading

OwenKephart commented Oct 24, 2024

OwenKephart commented Oct 24, 2024

cmpadden commented Oct 24, 2024

alangenfeld Oct 24, 2024

alangenfeld left a comment

		@@ -1,3 +1,3 @@
		"3.8":
		"3.9":

[1.9] Remove Python 3.8 Support #25523

[1.9] Remove Python 3.8 Support #25523

Conversation

OwenKephart commented Oct 24, 2024

Summary & Motivation

How I Tested These Changes

Changelog

OwenKephart commented Oct 24, 2024 • edited Loading

cmpadden left a comment

Choose a reason for hiding this comment

github-actions bot commented Oct 24, 2024 • edited Loading

github-actions bot commented Oct 24, 2024 • edited Loading

cmpadden commented Oct 24, 2024

OwenKephart commented Oct 24, 2024

github-actions bot commented Oct 24, 2024 • edited Loading

OwenKephart commented Oct 24, 2024

OwenKephart commented Oct 24, 2024

cmpadden commented Oct 24, 2024

alangenfeld Oct 24, 2024

Choose a reason for hiding this comment

alangenfeld left a comment

Choose a reason for hiding this comment

OwenKephart commented Oct 24, 2024 •

edited

Loading

github-actions bot commented Oct 24, 2024 •

edited

Loading

github-actions bot commented Oct 24, 2024 •

edited

Loading

github-actions bot commented Oct 24, 2024 •

edited

Loading