Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[du] updating based on API changes from 1dot7 #21725

Merged
merged 2 commits into from
May 13, 2024
Merged

[du] updating based on API changes from 1dot7 #21725

merged 2 commits into from
May 13, 2024

Conversation

tacastillo
Copy link
Contributor

@tacastillo tacastillo commented May 8, 2024 •
edited
Loading

Summary & Motivation

based on the API changes listed here https://www.notion.so/dagster/Proposal-of-DU-updates-for-1-7-2bd3ec68fc8b41dfa90099ade8d71a96

How I Tested These Changes

@tacastillo Graphite App
Copy link
Contributor Author

tacastillo commented May 8, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @tacastillo and the rest of your teammates on Graphite Graphite

@tacastillo tacastillo marked this pull request as ready for review May 8, 2024 17:06
@graphite-app graphite-app bot added the area: dagster-university Related to Dagster University label May 8, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented May 8, 2024

Deploy preview for dagster-docs ready!

Preview available at https://dagster-docs-afaw88qm8-elementl.vercel.app
https://05-08--du-updating-based-on-api-changes-from-1dot7.dagster.dagster-docs.io

Direct link to changed pages:

@cmpadden
Copy link
Contributor

cmpadden commented May 8, 2024 •
edited
Loading

Corresponding project pull request for tracking - dagster-io/project-dagster-university#25

@tacastillo tacastillo mentioned this pull request May 8, 2024
Merged
erinkcochran87
erinkcochran87 approved these changes May 9, 2024
View reviewed changes
Copy link
Contributor

@erinkcochran87 erinkcochran87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm good with this, assuming Colton is too!

@cmpadden
Copy link
Contributor

cmpadden commented May 9, 2024

Yup, @tacastillo just one tiny comment on if _ typehinting_ is one or two words, other than that lgtm.

@github-actions GitHub Actions
Copy link

Deploy preview for dagster-university ready!

✅ Preview
https://dagster-university-f2k7atzbe-elementl.vercel.app
https://05-08--du-updating-based-on-api-changes-from-1dot7.dagster-university.dagster-docs.io

Built with commit 73e96b1.
This pull request is being automatically deployed with vercel-action

@tacastillo Graphite App
Copy link
Contributor Author

tacastillo commented May 13, 2024 •
edited
Loading

Merge activity

  • May 13, 1:34 PM EDT: @tacastillo started a stack merge that includes this pull request via Graphite.
  • May 13, 1:36 PM EDT: Graphite rebased this pull request as part of a merge.
  • May 13, 1:37 PM EDT: @tacastillo merged this pull request with Graphite.

@tacastillo tacastillo force-pushed the 05-08-_du_updating_based_on_api_changes_from_1dot7 branch from 73e96b1 to bf879b5 Compare May 13, 2024 17:35
@tacastillo tacastillo merged commit 11011ab into master May 13, 2024
0 of 2 checks passed
@tacastillo tacastillo deleted the 05-08-_du_updating_based_on_api_changes_from_1dot7 branch May 13, 2024 17:37
danielgafni pushed a commit to danielgafni/dagster that referenced this pull request Jun 18, 2024
@tacastillo @danielgafni
[du] updating based on API changes from 1dot7 (dagster-io#21725)
2773529 
## Summary & Motivation

based on the API changes listed here https://www.notion.so/dagster/Proposal-of-DU-updates-for-1-7-2bd3ec68fc8b41dfa90099ade8d71a96

## How I Tested These Changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erinkcochran87 erinkcochran87 erinkcochran87 approved these changes

@cmpadden cmpadden cmpadden approved these changes

Assignees
No one assigned
Labels
area: dagster-university Related to Dagster University
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tacastillo @cmpadden @erinkcochran87