[components] Rename get_params_schema_type

dagster-io · Jan 16, 2025 · f8913e4 · f8913e4
1 parent 00bac33
commit f8913e4
Show file tree

Hide file tree

Showing 6 changed files with 6 additions and 8 deletions.
diff --git a/python_modules/libraries/dagster-components/dagster_components/cli/scaffold.py b/python_modules/libraries/dagster-components/dagster_components/cli/scaffold.py
@@ -62,9 +62,7 @@ def scaffold_component_command(
             raise Exception(
                 f"Component type {component_type} does not have a scaffolder. Reason: {scaffolder.message}."
             )
-        scaffold_params = TypeAdapter(scaffolder.get_params_schema_type()).validate_json(
-            json_params
-        )
+        scaffold_params = TypeAdapter(scaffolder.get_schema()).validate_json(json_params)
     else:
         scaffold_params = {}
 

diff --git a/python_modules/libraries/dagster-components/dagster_components/core/component.py b/python_modules/libraries/dagster-components/dagster_components/core/component.py
@@ -74,7 +74,7 @@ def get_metadata(cls) -> "ComponentTypeInternalMetadata":
             )
 
         component_params = cls.get_schema()
-        scaffold_params = scaffolder.get_params_schema_type()
+        scaffold_params = scaffolder.get_schema()
         return {
             "summary": clean_docstring.split("\n\n")[0] if clean_docstring else None,
             "description": clean_docstring if clean_docstring else None,

diff --git a/python_modules/libraries/dagster-components/dagster_components/core/component_scaffolder.py b/python_modules/libraries/dagster-components/dagster_components/core/component_scaffolder.py
@@ -15,7 +15,7 @@ class ComponentScaffoldRequest:
 
 class ComponentScaffolder:
     @classmethod
-    def get_params_schema_type(cls) -> Optional[type[BaseModel]]:
+    def get_schema(cls) -> Optional[type[BaseModel]]:
         return None
 
     @abstractmethod

diff --git a/python_modules/libraries/dagster-components/dagster_components/lib/dbt_project/scaffolder.py b/python_modules/libraries/dagster-components/dagster_components/lib/dbt_project/scaffolder.py
@@ -20,7 +20,7 @@ class DbtScaffoldParams(BaseModel):
 
 class DbtProjectComponentScaffolder(ComponentScaffolder):
     @classmethod
-    def get_params_schema_type(cls) -> Optional[type[BaseModel]]:
+    def get_schema(cls) -> Optional[type[BaseModel]]:
         return DbtScaffoldParams
 
     def scaffold(self, request: ComponentScaffoldRequest, params: DbtScaffoldParams) -> None:

diff --git a/...s/libraries/dagster-components/dagster_components/lib/definitions_component/scaffolder.py b/...s/libraries/dagster-components/dagster_components/lib/definitions_component/scaffolder.py
@@ -15,7 +15,7 @@ class DefinitionsScaffoldParams(BaseModel):
 
 class DefinitionsComponentScaffolder(ComponentScaffolder):
     @classmethod
-    def get_params_schema_type(cls):
+    def get_schema(cls):
         return DefinitionsScaffoldParams
 
     def scaffold(

diff --git a/...les/libraries/dagster-components/dagster_components/lib/test/simple_pipes_script_asset.py b/...les/libraries/dagster-components/dagster_components/lib/test/simple_pipes_script_asset.py
@@ -25,7 +25,7 @@ class SimplePipesScriptAssetParams(BaseModel):
 
 class SimplePipesScriptAssetScaffolder(ComponentScaffolder):
     @classmethod
-    def get_params_schema_type(cls):
+    def get_schema(cls):
         return SimplePipesScriptAssetParams
 
     def scaffold(