-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[Selection auto complete] Suggest "+" after digits. (#28121)
## Summary & Motivation The only possible continuation after typing digits is a `+` so lets suggest that. ## How I Tested These Changes jest + manual testing <img width="1231" alt="Screenshot 2025-02-28 at 9 22 17 AM" src="https://github.com/user-attachments/assets/620d767e-f2b9-4223-a73a-ba935faa09af" />
- Loading branch information
Showing
8 changed files
with
484 additions
and
265 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 changes: 2 additions & 1 deletion
3
js_modules/dagster-ui/packages/ui-core/src/selection/generated/SelectionAutoComplete.interp
Large diffs are not rendered by default.
Oops, something went wrong.
26 changes: 26 additions & 0 deletions
26
...ules/dagster-ui/packages/ui-core/src/selection/generated/SelectionAutoCompleteListener.ts
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Oops, something went wrong.
ef0670e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Deploy preview for dagit-core-storybook ready!
✅ Preview
https://dagit-core-storybook-12m1j3yzj-elementl.vercel.app
Built with commit ef0670e.
This pull request is being automatically deployed with vercel-action