also better error message

dagster-io · Feb 27, 2025 · ed3da84 · ed3da84
1 parent 68c0f66
commit ed3da84
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/js_modules/dagster-ui/packages/ui-core/src/selection/CustomErrorListener.ts b/js_modules/dagster-ui/packages/ui-core/src/selection/CustomErrorListener.ts
@@ -22,10 +22,14 @@ export class CustomErrorListener implements ANTLRErrorListener<any> {
     msg: string,
     _e: RecognitionException | undefined,
   ): void {
+    let from = charPositionInLine;
+    if (offendingSymbol?.text === '<EOF>') {
+      from = 0;
+    }
     this.errors.push({
       message: msg,
       offendingSymbol: offendingSymbol?.text,
-      from: charPositionInLine,
+      from,
       to: charPositionInLine + (offendingSymbol?.text?.length ?? Infinity),
     });
   }

diff --git a/...les/dagster-ui/packages/ui-core/src/selection/useSelectionInputLintingAndHighlighting.tsx b/...les/dagster-ui/packages/ui-core/src/selection/useSelectionInputLintingAndHighlighting.tsx
@@ -84,6 +84,10 @@ export const useSelectionInputLintingAndHighlighting = ({
       return null;
     }
     if (error.error.offendingSymbol) {
+      const symbol = error.error.offendingSymbol;
+      if (symbol === '<EOF>') {
+        return 'Selection is incomplete';
+      }
       return (
         <Box flex={{direction: 'row', alignItems: 'center'}}>
           Unexpected input