Skip to content

Commit

Permalink
[ui] Treat RESOURCE_INIT_FAILURE as a terminal step event (#28029)
Browse files Browse the repository at this point in the history
## Summary & Motivation

## How I Tested These Changes

Tested with the gzip run debug file in the ticket 


![image](https://github.com/user-attachments/assets/821810c2-1a0f-4e32-b09f-33ef0239d748)


## Changelog

[ui] Steps properly transition to failed in the Run gantt chart when
resource initialization fails.

Co-authored-by: bengotow <[email protected]>
  • Loading branch information
bengotow and bengotow authored Feb 28, 2025
1 parent 062837b commit b9baaab
Showing 1 changed file with 3 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -323,6 +323,9 @@ export function extractMetadataFromLogs(
} else if (log.__typename === 'ExecutionStepFailureEvent') {
upsertState(step, timestamp, IStepState.FAILED);
step.end = Math.max(timestamp, step.end || 0);
} else if (log.__typename === 'ResourceInitFailureEvent') {
upsertState(step, timestamp, IStepState.FAILED);
step.end = Math.max(timestamp, step.end || 0);
} else if (log.__typename === 'ExecutionStepUpForRetryEvent') {
// We only get one event when the step fails/aborts and is queued for retry,
// but we create an "exit" state separate from the "preparing for retry" state
Expand Down

1 comment on commit b9baaab

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deploy preview for dagit-core-storybook ready!

✅ Preview
https://dagit-core-storybook-2c4dtc6n8-elementl.vercel.app

Built with commit b9baaab.
This pull request is being automatically deployed with vercel-action

Please sign in to comment.