Skip to content

Commit

Permalink
[compute logs] fix download link in limit exceeded message (#28102)
Browse files Browse the repository at this point in the history
## How I Tested These Changes
![Screenshot 2025-02-27 at 1 53
56 PM](https://github.com/user-attachments/assets/98bde43b-0f7b-41ef-80a0-2ba34a02ac63)
  • Loading branch information
alangenfeld authored Feb 27, 2025
1 parent 53cba88 commit 46fb280
Showing 1 changed file with 5 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -317,6 +317,9 @@ const CapturedLogPanel = React.memo(

const stdoutLocation = queryResult.data?.capturedLogsMetadata.stdoutLocation || undefined;
const stderrLocation = queryResult.data?.capturedLogsMetadata.stderrLocation || undefined;
const stdoutDownloadUrl = queryResult.data?.capturedLogsMetadata.stdoutDownloadUrl;
const stderrDownloadUrl = queryResult.data?.capturedLogsMetadata.stderrDownloadUrl;

const websocketsUnavailabile = availability === 'unavailable' || disabled;
const Component = websocketsUnavailabile
? CapturedLogsQueryProvider
Expand All @@ -331,12 +334,14 @@ const CapturedLogPanel = React.memo(
isLoading={_state.isLoading}
location={stdoutLocation}
isVisible={visibleIOType === 'stdout'}
downloadUrl={stdoutDownloadUrl}
/>
<RawLogContent
logData={_state.stderr}
isLoading={_state.isLoading}
location={stderrLocation}
isVisible={visibleIOType === 'stderr'}
downloadUrl={stderrDownloadUrl}
/>
</>
)}
Expand Down

1 comment on commit 46fb280

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deploy preview for dagit-core-storybook ready!

✅ Preview
https://dagit-core-storybook-2ifxfi79f-elementl.vercel.app

Built with commit 46fb280.
This pull request is being automatically deployed with vercel-action

Please sign in to comment.