Skip to content

Commit

Permalink
[AssetSelection] Make operators case insensitive (#28300)
Browse files Browse the repository at this point in the history
## Summary & Motivation

As titled making operators case insensitive

## How I Tested These Changes

jest + pytest + local testing

<img width="902" alt="Screenshot 2025-03-06 at 3 26 29 PM"
src="https://github.com/user-attachments/assets/568b696c-05ef-47fc-9539-f04afd0f8dab"
/>
  • Loading branch information
salazarm authored Mar 7, 2025
1 parent 4787400 commit 057e495
Show file tree
Hide file tree
Showing 37 changed files with 778 additions and 659 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,11 @@ describe('parseAssetSelectionQuery', () => {
assertQueryResult('(key:A or key:B) and (key:B or key:C)', ['B']);
});

it('should parse not query', () => {
assertQueryResult('not key:A', ['B', 'B2', 'C']);
assertQueryResult('NOT key:A', ['B', 'B2', 'C']);
});

it('should parse upstream plus query', () => {
assertQueryResult('1+key:A', ['A']);
assertQueryResult('1+key:B', ['A', 'B']);
Expand Down Expand Up @@ -127,12 +132,14 @@ describe('parseAssetSelectionQuery', () => {
assertQueryResult('+key:B+', ['A', 'B', 'C']);
assertQueryResult('key:A+ and +key:C and +key:B+', ['A', 'B', 'C']);
assertQueryResult('key:A+ and +key:B+ and +key:C', ['A', 'B', 'C']);
assertQueryResult('key:A+ AND +key:B+ AND +key:C', ['A', 'B', 'C']);
});

it('should parse sinks query', () => {
assertQueryResult('sinks(*)', ['C']);
assertQueryResult('sinks(key:A)', ['A']);
assertQueryResult('sinks(key:A or key:B)', ['B']);
assertQueryResult('sinks(key:A OR key:B)', ['B']);
});

it('should parse roots query', () => {
Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

1 comment on commit 057e495

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deploy preview for dagit-core-storybook ready!

✅ Preview
https://dagit-core-storybook-10zw33me9-elementl.vercel.app

Built with commit 057e495.
This pull request is being automatically deployed with vercel-action

Please sign in to comment.