This repository was archived by the owner on Dec 21, 2025. It is now read-only.
Update .gitignore for current code layout and venv usage#309
Open
echoix wants to merge 1 commit intodabeaz:masterfrom
Open
Update .gitignore for current code layout and venv usage#309echoix wants to merge 1 commit intodabeaz:masterfrom
echoix wants to merge 1 commit intodabeaz:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The .gitignore has not been updated since the code layout has been changed a couple of years ago. For example, the pattern for .egg-info assumed the code was in
ply/, and now is insrc/ply/. In the same time frame, the makefile was tuned to create a venv, but wasn't ignored in the .gitignore.This PR addresses these two points, by ignoring
*.egg-infoin any subfolder, and also ignoring the .venv folder used.